Page MenuHomePhabricator
Differential D11473

Resolve an issue with Diffusion URI parsing ignoring some information
ClosedPublic
Actions

Authored by epriestley on Jan 23 2015, 11:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 8, 1:34 AM
Unknown Object (File)
Sat, Feb 8, 1:34 AM
Unknown Object (File)
Sat, Feb 8, 1:34 AM
Unknown Object (File)
Fri, Feb 7, 12:37 AM
Unknown Object (File)
Thu, Feb 6, 9:29 AM
Unknown Object (File)
Feb 1 2025, 1:03 PM
Unknown Object (File)
Jan 31 2025, 4:13 PM
Unknown Object (File)
Jan 25 2025, 12:12 AM
View All Files
Subscribers
epriestley
Tokens
"Like" token, awarded by epkugelmass.

Details

Reviewers
btrahan
chad
Maniphest Tasks
T7011: Edit Commit feature in Diffusion edits the wrong commit
Commits
Restricted Diffusion Commit
rP30eea5e93680: Resolve an issue with Diffusion URI parsing ignoring some information
Summary

Fixes T7011. Recent refactoring here caused us to begin ignoring URI parameters like commit. Most controllers take parameters as a dblob, which was still parsed properly.

Test Plan
  • Editing different commits actually edits the desired commits.
  • Browsed around some dblob pages and verified they still work properly.

Diff Detail

Repository
rP Phabricator
Branch
dxpath
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4008
Build 4021: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27599.Jan 23 2015, 11:39 AM
epriestley retitled this revision from to Resolve an issue with Diffusion URI parsing ignoring some information.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added a task: T7011: Edit Commit feature in Diffusion edits the wrong commit.
Herald added a subscriber: epriestley. · View Herald TranscriptJan 23 2015, 11:39 AM
chad accepted this revision.Jan 23 2015, 3:15 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 23 2015, 3:15 PM
Closed by commit rP30eea5e93680: Resolve an issue with Diffusion URI parsing ignoring some information (authored by epriestley, committed by epriestley). · Explain WhyJan 23 2015, 4:36 PM
This revision was automatically updated to reflect the committed changes.
btrahan edited edge metadata.Jan 23 2015, 6:26 PM

Thanks for the fix!

epkugelmass awarded a token.Jan 23 2015, 6:58 PM

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
request/
12 lines

Diff 27599

View Options

src/applications/diffusion/request/DiffusionRequest.php

Loading...
Phabricator · Built by Phacility