Paths

Table of Contentst

Differential D11466

Add return type to `conduit.query`
ClosedPublic
Actions

Authored by joshuaspence on Jan 22 2015, 11:20 AM.

Tags

None

Referenced Files

	F13531398: D11466.diff
	Sat, Jul 27, 5:16 AM

	Unknown Object (File)
	Wed, Jul 24, 10:35 AM

	Unknown Object (File)
	Mon, Jul 22, 4:14 AM

	Unknown Object (File)
	Mon, Jul 22, 4:13 AM

	Unknown Object (File)
	Mon, Jul 22, 4:13 AM

	Unknown Object (File)
	Fri, Jul 19, 8:06 AM

	Unknown Object (File)
	Thu, Jul 18, 10:23 AM

	Unknown Object (File)
	Mon, Jul 15, 2:25 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6950: conduit.query should provide return values

Commits

Restricted Diffusion Commit
rP1258ed348b44: Add return type to `conduit.query`

Summary

Fixes T6950. Adds the return type of Conduit API methods to the conduit.query call.

Test Plan

Called echo '{}' | arc call-conduit conduit.query and verified that the return types were present in the response.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3985
Build 3998: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27562.Jan 22 2015, 11:20 AM

joshuaspence retitled this revision from to Add return type to `conduit.query`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T6950: conduit.query should provide return values.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 22 2015, 11:20 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

If you want to dump name/description in here, that'd be reasonable too. The only thing I'd hold back is "errors" since I think we got that wrong in a few ways (e.g., many different errors which all mean "no matching object").

This revision is now accepted and ready to land.Jan 22 2015, 8:13 PM

Oh, see D11467.

Closed by commit rP1258ed348b44: Add return type to `conduit.query` (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 22 2015, 8:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

method/

ConduitQueryConduitAPIMethod.php

1 line

Diff 27562

src/applications/conduit/method/ConduitQueryConduitAPIMethod.php

Loading...