Page MenuHomePhabricator

Add return type to `conduit.query`

Authored by joshuaspence on Jan 22 2015, 11:20 AM.
Referenced Files
F13036266: D11466.diff
Sun, Apr 14, 5:24 PM
Unknown Object (File)
Thu, Apr 11, 9:06 AM
Unknown Object (File)
Tue, Apr 9, 11:42 AM
Unknown Object (File)
Sat, Apr 6, 1:32 AM
Unknown Object (File)
Thu, Mar 28, 9:13 PM
Unknown Object (File)
Thu, Mar 28, 9:13 PM
Unknown Object (File)
Thu, Mar 28, 8:51 PM
Unknown Object (File)
Mon, Mar 25, 11:36 AM



Fixes T6950. Adds the return type of Conduit API methods to the conduit.query call.

Test Plan

Called echo '{}' | arc call-conduit conduit.query and verified that the return types were present in the response.

Diff Detail

rP Phabricator
Lint Passed
No Test Coverage
Build Status
Buildable 3985
Build 3998: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Add return type to `conduit.query`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

If you want to dump name/description in here, that'd be reasonable too. The only thing I'd hold back is "errors" since I think we got that wrong in a few ways (e.g., many different errors which all mean "no matching object").

This revision is now accepted and ready to land.Jan 22 2015, 8:13 PM
This revision was automatically updated to reflect the committed changes.