Improve handling of options for `arc` workflows
ClosedPublic
Actions

Authored by joshuaspence on Jan 22 2015, 12:28 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC937861ce58c9: Improve handling of options for `arc` workflows

Summary

Allow --severity=warning to mean the same as --severity warning. Longer term, we should convert this code to use PhutilArgumentParser, although it doesn't seem that PhutilArgumentParser support British spelling ;)

Test Plan

Ran arc lint --severity=warning. Also var_dumped $args to make sure it looked reasonable.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27560.Jan 22 2015, 12:28 AM

joshuaspence retitled this revision from to Improve handling of options for `arc` workflows.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 22 2015, 12:28 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence updated this object.Jan 22 2015, 7:15 AM

joshuaspence edited edge metadata.

joshuaspence edited the test plan for this revision. (Show Details)Jan 22 2015, 7:17 AM

epriestley accepted this revision.Jan 22 2015, 8:04 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 22 2015, 8:04 PM

Closed by commit rARC937861ce58c9: Improve handling of options for `arc` workflows (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 22 2015, 8:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistWorkflow.php

13 lines

Diff 27566

View Options

src/workflow/ArcanistWorkflow.php

Improve handling of options for `arc` workflowsClosedPublicActions