Tags

None

Referenced Files

	F19081726: D11445.id27507.diff
	Dec 2 2025, 8:12 AM

	F19057298: D11445.diff
	Nov 28 2025, 9:55 PM

	F19057235: D11445.diff
	Nov 28 2025, 9:39 PM

	F18847372: D11445.id27518.diff
	Oct 30 2025, 12:17 AM

	F18816647: D11445.id.diff
	Oct 21 2025, 8:29 AM

	F18782067: D11445.id27509.diff
	Oct 13 2025, 12:28 AM

	F18756149: D11445.id27508.diff
	Oct 5 2025, 9:35 AM

	F18756090: D11445.id27507.diff
	Oct 5 2025, 9:15 AM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Maniphest Tasks

T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune

Commits

Restricted Diffusion Commit
rP77bcbed9f98e: Implement PolicyAwareQuery for triggers

Summary

Ref T6881. I tried to cheat here by not implementing this, but we need it for destroying triggers directly with bin/remove destroy, since that needs to load them by PHID.

So, cheat slightly less. Implement PolicyAware but not CursorPagedPolicyAware.

Test Plan

Used bin/remove destroy to destroy a trigger by PHID.
Browsed daemon console.
Ran trigger daemon.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 27506.Jan 20 2015, 4:12 PM

epriestley retitled this revision from to Implement PolicyAwareQuery for triggers.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 20 2015, 4:12 PM

Also fix bad newObject() implementation.

Missed a spot.

Small fix to getNextEventPrediction() for scheduled events.

LGTM

src/infrastructure/daemon/workers/storage/PhabricatorWorkerTrigger.php
186–188	Consider moving this up to just below the fancy PolicyInterface declaration.

This revision is now accepted and ready to land.Jan 20 2015, 6:25 PM

Scope comment more clearly.

Closed by commit rP77bcbed9f98e: Implement PolicyAwareQuery for triggers (authored by epriestley, committed by epriestley). · Explain WhyJan 20 2015, 9:33 PM

This revision was automatically updated to reflect the committed changes.

Implement PolicyAwareQuery for triggers
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 27518

src/__phutil_library_map__.php

src/applications/daemon/controller/PhabricatorDaemonConsoleController.php

src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php

src/infrastructure/daemon/workers/management/PhabricatorWorkerTriggerManagementWorkflow.php

src/infrastructure/daemon/workers/phid/PhabricatorWorkerTriggerPHIDType.php

src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php

src/infrastructure/daemon/workers/storage/PhabricatorWorkerTrigger.php

Implement PolicyAwareQuery for triggersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27518

src/__phutil_library_map__.php

src/applications/daemon/controller/PhabricatorDaemonConsoleController.php

src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php

src/infrastructure/daemon/workers/management/PhabricatorWorkerTriggerManagementWorkflow.php

src/infrastructure/daemon/workers/phid/PhabricatorWorkerTriggerPHIDType.php

src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php

src/infrastructure/daemon/workers/storage/PhabricatorWorkerTrigger.php

Implement PolicyAwareQuery for triggers
ClosedPublic
Actions

Revision Contents
Changeset List