Page MenuHomePhabricator
Differential D11445

Implement PolicyAwareQuery for triggers
ClosedPublic
Actions

Authored by epriestley on Jan 20 2015, 4:12 PM.
Tags
None
Referenced Files
F13208973: D11445.id27507.diff
Thu, May 16, 8:43 PM
F13176420: D11445.id27510.diff
Wed, May 8, 1:47 PM
Unknown Object (File)
Sun, May 5, 11:13 PM
Unknown Object (File)
Sun, May 5, 5:40 AM
Unknown Object (File)
Fri, May 3, 3:20 AM
Unknown Object (File)
Mon, Apr 29, 2:47 PM
Unknown Object (File)
Wed, Apr 24, 10:46 PM
Unknown Object (File)
Mon, Apr 22, 6:39 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune
Commits
Restricted Diffusion Commit
rP77bcbed9f98e: Implement PolicyAwareQuery for triggers
Summary

Ref T6881. I tried to cheat here by not implementing this, but we need it for destroying triggers directly with bin/remove destroy, since that needs to load them by PHID.

So, cheat slightly less. Implement PolicyAware but not CursorPagedPolicyAware.

Test Plan
  • Used bin/remove destroy to destroy a trigger by PHID.
  • Browsed daemon console.
  • Ran trigger daemon.

Diff Detail

Repository
rP Phabricator
Branch
trigger8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3941
Build 3954: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27506.Jan 20 2015, 4:12 PM
epriestley retitled this revision from to Implement PolicyAwareQuery for triggers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune.
Herald added a subscriber: epriestley. · View Herald TranscriptJan 20 2015, 4:12 PM
epriestley updated this revision to Diff 27507.Jan 20 2015, 4:14 PM
  • Also fix bad newObject() implementation.
epriestley updated this revision to Diff 27508.Jan 20 2015, 4:15 PM
  • Missed a spot.
epriestley updated this revision to Diff 27509.Jan 20 2015, 4:19 PM
  • Small fix to getNextEventPrediction() for scheduled events.
btrahan accepted this revision.Jan 20 2015, 6:25 PM
btrahan edited edge metadata.

LGTM

src/infrastructure/daemon/workers/storage/PhabricatorWorkerTrigger.php
186–188

Consider moving this up to just below the fancy PolicyInterface declaration.

This revision is now accepted and ready to land.Jan 20 2015, 6:25 PM
epriestley updated this revision to Diff 27510.Jan 20 2015, 7:31 PM
epriestley edited edge metadata.
  • Scope comment more clearly.
Closed by commit rP77bcbed9f98e: Implement PolicyAwareQuery for triggers (authored by epriestley, committed by epriestley). · Explain WhyJan 20 2015, 9:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
daemon/
controller/
10 lines
infrastructure/
daemon/
workers/
3 lines
management/
1 line
phid/
10 lines
query/
18 lines
storage/
31 lines

Diff 27510

View Options

src/applications/daemon/controller/PhabricatorDaemonConsoleController.php

Loading...
View Options

src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php

Loading...
View Options

src/infrastructure/daemon/workers/management/PhabricatorWorkerTriggerManagementWorkflow.php

Loading...
View Options

src/infrastructure/daemon/workers/phid/PhabricatorWorkerTriggerPHIDType.php

Loading...
View Options

src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php

Loading...
View Options

src/infrastructure/daemon/workers/storage/PhabricatorWorkerTrigger.php

Loading...
Phabricator · Built by Phacility