Differential D11432

Use strict mode for Javelin core
ClosedPublic
Actions

Authored by joshuaspence on Jan 19 2015, 9:49 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP98a8d44f114d: Use strict mode for Javelin core

Summary

Enable strict mode for Javelin when running in NodeJS.

Test Plan

Made sure Aphlict still worked.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	webroot/rsrc/externals/javelin/core/init_node.js:1	JAVELIN5	`javelinsymbols` Not In Path

Unit

No Test Coverage

Build Status

Buildable 3915
Build 3928: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27470.Jan 19 2015, 9:49 PM

joshuaspence retitled this revision from to Use strict mode for Javelin core.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 19 2015, 9:49 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 19 2015, 9:51 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 19 2015, 9:51 PM

Closed by commit rP98a8d44f114d: Use strict mode for Javelin core (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 19 2015, 9:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

webroot/

rsrc/

externals/

javelin/

core/

init_node.js

2 lines

Diff 27470

View Options

webroot/rsrc/externals/javelin/core/init_node.js

Use strict mode for Javelin coreClosedPublicActions