Page MenuHomePhabricator
Differential D11397

Don't try to create the Aphlict log directory if it already exists
ClosedPublic
Actions

Authored by joshuaspence on Jan 14 2015, 8:59 PM.
Tags
None
Referenced Files
F15164154: D11397.id27388.diff
Tue, Feb 18, 12:36 PM
Unknown Object (File)
Mon, Feb 10, 9:29 AM
Unknown Object (File)
Sat, Feb 8, 1:10 AM
Unknown Object (File)
Sat, Feb 8, 1:10 AM
Unknown Object (File)
Sat, Feb 8, 1:10 AM
Unknown Object (File)
Sat, Feb 8, 1:10 AM
Unknown Object (File)
Mon, Feb 3, 11:04 AM
Unknown Object (File)
Thu, Jan 23, 9:51 PM
View All Files
Subscribers
epriestley
Korvin
maxhodak

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6944: Try to create the pid directory in Aphlict
Commits
Restricted Diffusion Commit
rP487eb4e916d2: Don't try to create the Aphlict log directory if it already exists
Summary

Ref T6944. This was not quite implemented correctly in D11387.

Test Plan

Saw no more exceptions about being unable to create /var/log.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3850
Build 3862: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27373.Jan 14 2015, 8:59 PM
joshuaspence retitled this revision from to Don't try to create the Aphlict log directory if it already exists.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6944: Try to create the pid directory in Aphlict.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 14 2015, 8:59 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this object.Jan 14 2015, 10:41 PM
joshuaspence edited edge metadata.
maxhodak added a subscriber: maxhodak.Jan 15 2015, 6:15 AM
epriestley accepted this revision.Jan 15 2015, 6:54 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 15 2015, 6:54 AM
Closed by commit rP487eb4e916d2: Don't try to create the Aphlict log directory if it already exists (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 15 2015, 7:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
aphlict/
management/
4 lines

Diff 27373

View Options

src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php

Loading...
Phabricator · Built by Phacility