last block-level children
ClosedPublic
Actions

Authored by matmarex on Jan 14 2015, 6:56 AM.

Details

Reviewers

epriestley
chad

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6968: Bottom margin inconsistent for paragraphs/lists that are last children in comments

Commits

Restricted Diffusion Commit
rP2297a43d446b: remarkup.css: Consistently zero top/bottom margins for first/last block-level…

Summary

For block-level elements that have a margin-top or margin-bottom set
(generally to 12px), also reset the appropriate margin to 0 when
they're a first-child or last-child of their parents.

The change doesn't affect nested lists, their selector is more specific.

Test Plan

Look at some comments or wiki documents that end with different
block elements, verify that the margins are pretty.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 3844
Build 3856: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

matmarex updated this revision to Diff 27342.Jan 14 2015, 6:56 AM

matmarex retitled this revision from to remarkup.css: Consistently zero top/bottom margins for first/last block-level children.

matmarex updated this object.

matmarex edited the test plan for this revision. (Show Details)

matmarex added a reviewer: epriestley.

matmarex set the repository for this revision to rP Phabricator.

matmarex added a project: Remarkup.

Herald added reviewers: chad, Blessed Reviewers. · View Herald TranscriptJan 14 2015, 6:56 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

matmarex added a task: T6968: Bottom margin inconsistent for paragraphs/lists that are last children in comments.Jan 14 2015, 6:56 AM

Am I expected to include the result of running bin/celerity map in the diff? That feels like something that should be done automatically on merge, since it would cause tons of merge conflicts otherwise, but I see it in some commits in Git.