Page MenuHomePhabricator
Differential D11371

Make Workboard icon grey if not enabled
ClosedPublic
Actions

Authored by chad on Jan 13 2015, 5:20 PM.
Tags
None
Referenced Files
F13235216: D11371.diff
Tue, May 21, 4:28 AM
F13212723: D11371.diff
Fri, May 17, 7:00 AM
F13206654: D11371.diff
Wed, May 15, 2:23 PM
F13197644: D11371.diff
Mon, May 13, 12:21 AM
Unknown Object (File)
Fri, May 3, 10:08 AM
Unknown Object (File)
Tue, Apr 30, 4:14 AM
Unknown Object (File)
Thu, Apr 25, 3:34 AM
Unknown Object (File)
Apr 11 2024, 10:49 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP7e78a3f90609: Make Workboard icon grey if not enabled
Summary

Not sure this is obvious enough, but maybe future apps will use as well?

Test Plan

test a project with and without a workboard

Diff Detail

Repository
rP Phabricator
Branch
grey-icon-board
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3816
Build 3828: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 27304.Jan 13 2015, 5:20 PM
chad retitled this revision from to Make Workboard icon grey if not enabled.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 13 2015, 5:20 PM
chad added a comment.Jan 13 2015, 5:21 PM

pasted_file (349×387 px, 50 KB)

epriestley accepted this revision.Jan 13 2015, 5:39 PM
epriestley edited edge metadata.

Doing an extra query for this isn't ideal, but there's no easy way around it and we can set some flag on the Project eventually. I think that would save a query or two elsewhere, too. I'll file a followup.

I think the grey is nice as a hint.

src/applications/project/controller/PhabricatorProjectController.php
41

This can be simplified as $this->getViewer() nowadays.

Prefer $viewer (over $user) in modern code for consistency/clarity.

This revision is now accepted and ready to land.Jan 13 2015, 5:39 PM
epriestley mentioned this in T6961: Rendering of workboard columns on card objects could be marginally more efficient.Jan 13 2015, 5:43 PM
Closed by commit rP7e78a3f90609: Make Workboard icon grey if not enabled (authored by chad, committed by chad). · Explain WhyJan 13 2015, 5:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
project/
controller/
13 lines

Diff 27304

View Options

src/applications/project/controller/PhabricatorProjectController.php

Loading...
Phabricator · Built by Phacility