Page MenuHomePhabricator
Differential D11350

Improve lint handling of `declare()` special statement blocks
ClosedPublic
Actions

Authored by joshuaspence on Jan 12 2015, 8:20 PM.
Tags
None
Referenced Files
F15199048: D11350.diff
Sun, Feb 23, 6:22 AM
Unknown Object (File)
Sat, Feb 8, 1:04 AM
Unknown Object (File)
Sat, Feb 8, 1:04 AM
Unknown Object (File)
Sat, Feb 8, 1:04 AM
Unknown Object (File)
Sat, Feb 8, 1:04 AM
Unknown Object (File)
Sun, Feb 2, 9:50 PM
Unknown Object (File)
Thu, Jan 30, 5:51 AM
Unknown Object (File)
Tue, Jan 28, 3:14 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6830: Improve lint handling of declare() special statement blocks
Commits
rARCaf4ab07381a5: Improve lint handling of `declare()` special statement blocks
Summary

Fixes T6830. Don't require n_STATEMENT nested under n_DECLARE to be written using braces.

Test Plan

Added a test case.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3791
Build 3803: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27270.Jan 12 2015, 8:20 PM
joshuaspence retitled this revision from to Improve lint handling of `declare()` special statement blocks.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6830: Improve lint handling of declare() special statement blocks.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 12 2015, 8:20 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 12 2015, 8:22 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 12 2015, 8:22 PM
Closed by commit rARCaf4ab07381a5: Improve lint handling of `declare()` special statement blocks (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 12 2015, 8:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
7 lines
__tests__/
xhpast/
4 lines

Diff 27270

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/creative-brace-use.lint-test

Loading...
Phabricator · Built by Phacility