Page MenuHomePhabricator
Differential D11341

Add unit tests for `ArcanistFilenameLinter`
ClosedPublic
Actions

Authored by joshuaspence on Jan 12 2015, 8:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 4:56 PM
Unknown Object (File)
Oct 20 2024, 10:12 AM
Unknown Object (File)
Oct 19 2024, 3:35 AM
Unknown Object (File)
Oct 18 2024, 5:37 PM
Unknown Object (File)
Oct 18 2024, 5:51 AM
Unknown Object (File)
Oct 16 2024, 1:31 PM
Unknown Object (File)
Oct 14 2024, 3:04 PM
Unknown Object (File)
Oct 12 2024, 9:12 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCf58642a8ab99: Add unit tests for `ArcanistFilenameLinter`
Summary

Self-explanatory.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3778
Build 3789: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27245.Jan 12 2015, 8:06 AM
joshuaspence retitled this revision from to Add unit tests for `ArcanistFilenameLinter`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 12 2015, 8:06 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 27247.Jan 12 2015, 9:04 AM
joshuaspence edited edge metadata.

Minor fix

epriestley requested changes to this revision.Jan 12 2015, 4:06 PM
epriestley edited edge metadata.

See inline.

src/lint/linter/__tests__/ArcanistLinterTestCase.php
211

I don't think this is right? $pos will alway be a scalar, and this will always cast it into array($pos) and always discard character information.

$ php -r 'list($a, $b) = explode(":", "1:2:3"); $b = (array)$b; print_r($b);'
Array
(
    [0] => 2
)
This revision now requires changes to proceed.Jan 12 2015, 4:06 PM
epriestley added a comment.Jan 12 2015, 4:07 PM

The code would work as written if list($a, $b) unpacked the first argument into $a and all remaining arguments into $b, but list() does not do that. Maybe that was the thinking?

joshuaspence added a comment.Jan 12 2015, 7:42 PM
In D11341#105984, @epriestley wrote:

The code would work as written if list($a, $b) unpacked the first argument into $a and all remaining arguments into $b, but list() does not do that. Maybe that was the thinking?

Yeah, for some reason I thought that PHP was a sane language.

joshuaspence updated this revision to Diff 27266.Jan 12 2015, 7:45 PM
joshuaspence edited edge metadata.

Learn how PHP works

epriestley accepted this revision.Jan 12 2015, 7:46 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 12 2015, 7:46 PM
Closed by commit rARCf58642a8ab99: Add unit tests for `ArcanistFilenameLinter` (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 12 2015, 7:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27245

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/engine/ArcanistUnitTestableLintEngine.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistFilenameLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/filename/bad_filename.lint-test

Loading...
View Options

src/lint/linter/__tests__/filename/good_filename.lint-test

Loading...
Phabricator · Built by Phacility