Currently, a lot of ArcanistExternalLinter subclasses have something like this:
if ($err && !$messages) { return false; }
We can avoid this code duplication by moving this check to the ArcanistExternalLinter class.
Differential D11321
Improve behavior for detecting the failure to parse external linter output joshuaspence on Jan 11 2015, 9:30 AM. Authored by Tags None Referenced Files
Subscribers
Details
Currently, a lot of ArcanistExternalLinter subclasses have something like this: if ($err && !$messages) { return false; } We can avoid this code duplication by moving this check to the ArcanistExternalLinter class. arc unit
Diff Detail
|