Page MenuHomePhabricator

Improve behavior for detecting the failure to parse external linter output
ClosedPublic

Authored by joshuaspence on Jan 11 2015, 9:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 7:36 AM
Unknown Object (File)
Tue, Nov 12, 7:37 AM
Unknown Object (File)
Fri, Nov 8, 3:54 AM
Unknown Object (File)
Wed, Nov 6, 1:16 AM
Unknown Object (File)
Sun, Nov 3, 6:57 AM
Unknown Object (File)
Sun, Nov 3, 6:56 AM
Unknown Object (File)
Fri, Nov 1, 7:19 AM
Unknown Object (File)
Sat, Oct 26, 5:20 PM
Subscribers

Details

Summary

Currently, a lot of ArcanistExternalLinter subclasses have something like this:

if ($err && !$messages) {
  return false;
}

We can avoid this code duplication by moving this check to the ArcanistExternalLinter class.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Improve behavior for detecting.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence retitled this revision from Improve behavior for detecting to Improve behavior for detecting the failure to parse external linter output.Jan 11 2015, 7:55 PM
joshuaspence edited edge metadata.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 20 2015, 2:02 PM
This revision was automatically updated to reflect the committed changes.