Page MenuHomePhabricator

Pass `--error-level=all` to `puppet-lint`
ClosedPublic

Authored by joshuaspence on Jan 11 2015, 6:04 AM.
Tags
None
Referenced Files
F13999091: D11316.diff
Thu, Oct 24, 12:52 PM
F13993980: D11316.id27212.diff
Wed, Oct 23, 2:53 AM
F13967213: D11316.id.diff
Wed, Oct 16, 12:17 PM
Unknown Object (File)
Sep 20 2024, 11:41 AM
Unknown Object (File)
Aug 28 2024, 7:47 PM
Unknown Object (File)
Aug 28 2024, 1:26 PM
Unknown Object (File)
Aug 28 2024, 11:26 AM
Unknown Object (File)
Aug 17 2024, 6:15 AM
Subscribers

Details

Summary

Without explicitly passing --error-level=all to puppet-lint, the configuration file for puppet-lint could contain --error-level=error. This would limit the ability of arc lint to detect linter issues and therefore we should override this flag from the command line explicitly.

Test Plan

This is mostly theoretical.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3743
Build 3754: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Pass `--error-level=all` to `puppet-lint`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 11 2015, 4:56 PM
This revision was automatically updated to reflect the committed changes.