Page MenuHomePhabricator

Improve parsing of `csslint` output
ClosedPublic

Authored by joshuaspence on Jan 11 2015, 1:48 AM.
Tags
None
Referenced Files
F14077659: D11311.diff
Fri, Nov 22, 12:47 AM
Unknown Object (File)
Sun, Nov 17, 11:05 PM
Unknown Object (File)
Thu, Nov 14, 6:48 AM
Unknown Object (File)
Wed, Nov 13, 2:51 AM
Unknown Object (File)
Sun, Nov 10, 7:06 AM
Unknown Object (File)
Wed, Nov 6, 3:06 PM
Unknown Object (File)
Thu, Oct 24, 3:39 PM
Unknown Object (File)
Oct 21 2024, 12:33 PM
Subscribers

Details

Summary

csslint returns an evidence field which contains the line of the "original text" which produced the linter message (see https://github.com/CSSLint/csslint/blob/5dd84b259b90c5ea8adbaf03d31e9df093cc3dcd/src/core/Reporter.js#L64). We can use this data instead of trying to achieve the same result using $this->getData($path).

Test Plan

csslint (362×611 px, 29 KB)

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3737
Build 3748: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Improve parsing of `csslint` output.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.
joshuaspence updated this object.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 11 2015, 5:38 PM
This revision was automatically updated to reflect the committed changes.