Page MenuHomePhabricator

Improve parsing of `csslint` output
ClosedPublic

Authored by joshuaspence on Jan 11 2015, 1:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 1, 5:03 PM
Unknown Object (File)
Sun, Sep 1, 2:39 PM
Unknown Object (File)
Tue, Aug 27, 8:41 AM
Unknown Object (File)
Sun, Aug 25, 9:07 PM
Unknown Object (File)
Sun, Aug 25, 6:22 PM
Unknown Object (File)
Thu, Aug 22, 2:52 PM
Unknown Object (File)
Thu, Aug 22, 12:58 AM
Unknown Object (File)
Wed, Aug 21, 11:27 PM
Subscribers

Details

Summary

csslint returns an evidence field which contains the line of the "original text" which produced the linter message (see https://github.com/CSSLint/csslint/blob/5dd84b259b90c5ea8adbaf03d31e9df093cc3dcd/src/core/Reporter.js#L64). We can use this data instead of trying to achieve the same result using $this->getData($path).

Test Plan

csslint (362×611 px, 29 KB)

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Improve parsing of `csslint` output.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.
joshuaspence updated this object.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 11 2015, 5:38 PM
This revision was automatically updated to reflect the committed changes.