This is a little rough and should be considered an "advanced" option. Having said that, this works well in my install and I imagine that other installs will find this beneficial.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rP44f2195eec21: Add documentation for routing WebSockets through a reverse proxy
Eyeball it.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 3706 Build 3717: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/docs/user/configuration/notifications.diviner | ||
|---|---|---|
| 121 | "this approaching" -> "this approach" | |
| 121 | "is termination" -> "is terminated" | |
| 121–125 | This argument isn't terribly compelling, since you're trading 2 config options for a page of them. Maybe emphasize that you don't have to duplicate configuration or similar. (This setup simply seems more complicated to me, though.) One-point-five things that might be worth mentioning:
| |
| 127 | Maybe mention that these paths are examples or something -- we really should not have to do this, but users are crazily excited about taking everything literally. | |
| 145 | One downside to this approach is that you'll send authentication cookies to the Node server. Although it seems unlikely that an attacker could gain any kind of access which would make this relevant, I figured I'd mention it. | |