Page MenuHomePhabricator

Maniphest / Workboards - show workboard column when adding a project to a task
ClosedPublic

Authored by btrahan on Jan 6 2015, 10:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 4:49 PM
Unknown Object (File)
Fri, Dec 27, 4:32 AM
Unknown Object (File)
Tue, Dec 24, 7:38 AM
Unknown Object (File)
Sat, Dec 21, 3:00 AM
Unknown Object (File)
Wed, Dec 18, 3:33 AM
Unknown Object (File)
Fri, Dec 13, 8:41 AM
Unknown Object (File)
Nov 30 2024, 6:34 AM
Unknown Object (File)
Nov 29 2024, 11:37 PM
Subscribers

Details

Summary

Fixes T6471. This makes adding projects to tasks have better workflow towards boards; without it, you have to click project -> board -> do stuff on board as opposed to column -> do stuff on board.

Test Plan

added and removed projets. saw column listed parenthetcally when expected

Diff Detail

Repository
rP Phabricator
Branch
T6471
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3650
Build 3660: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Maniphest / Workboards - show workboard column when adding a project to a task.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2015, 10:30 PM

This is vaaaguely bad if some project ever has 50000 columns, but we can cross that bridge when we come to it.

We can limit the columns query to just active columns maybe?

We can assume that its going to be the default column if a default column exists and there's no position, but getting the default column still requires getting all columns as far as I know. Ergo, still need to load all active columns I think...

This revision was automatically updated to reflect the committed changes.

I don't think it's a problem for today.

5 years from now some project might have (5 * 50 ~= 250) sprint subprojects which generate columns or something, and maybe they never get auto-archived, but we have a few years before we're likely to run into that on realistic installs.