Page MenuHomePhabricator

Workboards - start showing "reload the page" bubble if a pertinent task is updated
AbandonedPublic

Authored by btrahan on Jan 6 2015, 7:13 PM.

Details

Summary

Ref T6179. T6179 implies that there is automagical updating of things like a task title, but that doesn't seem to work for me? Just double checking this isn't supposed to do some sort of automagic upates already...

Start making this better with the simplest sauce we already deploy liberally - make the pageObjects be all the tasks that originally loaded, which in turn displays notifications and a "reload" bubble to the user if / when tasks are updated in some other browser.

Test Plan

opened a workboard in browser a, and then edited some associated tasks in browser b. got the 'task x updated' notification and a "reload" bubble.

Diff Detail

Repository
rP Phabricator
Branch
T6179
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 3641
Build 3650: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 27018.Jan 6 2015, 7:13 PM
btrahan retitled this revision from to Workboards - start showing "reload the page" bubble if a pertinent task is updated.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley accepted this revision.Jan 6 2015, 7:22 PM
epriestley edited edge metadata.

No automatic update is expected.

T6179 is only talking about the case where you edit the card and remove a project. We do automatically update after edits (the response includes a fresh rendering of the card), just not on the notification channel.

This will get a couple of edge cases not-quite-right:

  • After T6179, you'll still get alerts for cards which have been removed.
  • You won't get alerts for new cards added after you loaded the page.
This revision is now accepted and ready to land.Jan 6 2015, 7:22 PM

Oh okay... I'll probably hold this then in favor of T4900 then, or at least getting T6179 actually fixed and then handling the corner cases correctly with this.

btrahan abandoned this revision.Jan 6 2015, 9:22 PM

This might be re-abandoned or collapsed into some larger diff at some point, but no point in holding on to it 'cuz its easy peasy.