Page MenuHomePhabricator
Differential D11254

Don't try to call library functions during arc sanity checking
ClosedPublic
Actions

Authored by epriestley on Jan 6 2015, 5:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 3, 11:59 PM
Unknown Object (File)
Fri, Jan 3, 5:54 PM
Unknown Object (File)
Fri, Dec 27, 11:25 PM
Unknown Object (File)
Fri, Dec 27, 6:06 PM
Unknown Object (File)
Fri, Dec 27, 3:54 AM
Unknown Object (File)
Sat, Dec 21, 5:43 PM
Unknown Object (File)
Sun, Dec 15, 7:45 PM
Unknown Object (File)
Sat, Dec 14, 5:21 AM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
btrahan
chad
Commits
rARC2035330780a4: Don't try to call library functions during arc sanity checking
Summary

These functions won't exist yet. See https://github.com/phacility/arcanist/commit/7e2df9a5bfc635b77c6412ef5a6569edd0e4e138#commitcomment-9172274

Test Plan

Faked a fatal, ran arc, got message.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 27009.Jan 6 2015, 5:38 PM
epriestley retitled this revision from to Don't try to call library functions during arc sanity checking.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence, chad.
Herald added a subscriber: epriestley. · View Herald TranscriptJan 6 2015, 5:38 PM
btrahan accepted this revision.Jan 6 2015, 5:52 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2015, 5:52 PM
Closed by commit rARC2035330780a4: Don't try to call library functions during arc sanity checking (authored by epriestley, committed by epriestley). · Explain WhyJan 6 2015, 5:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
scripts/
12 lines

Diff 27010

View Options

scripts/arcanist.php

Loading...
Phabricator · Built by Phacility