Paths

Table of Contentst

Differential D11225

Disable S3 file storage engine without credentials
AbandonedPublic
Actions

Authored by epriestley on Jan 5 2015, 9:06 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 21, 12:37 PM

	Unknown Object (File)
	Sun, Nov 17, 3:49 AM

	Unknown Object (File)
	Oct 18 2024, 11:05 AM

	Unknown Object (File)
	Sep 10 2024, 12:15 AM

	Unknown Object (File)
	Sep 4 2024, 4:56 AM

	Unknown Object (File)
	Aug 30 2024, 10:32 PM

	Unknown Object (File)
	Aug 22 2024, 4:38 PM

	Unknown Object (File)
	Aug 21 2024, 2:02 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Summary

Check whether amazon-s3.access-key is set when selecting PhabricatorS3FileStorageEngine. On my install I am using a custom PhabricatorFileStorageEngine subclass which connects to S3 using IAM credentials, therefore amazon-s3.access-key (and also amazon-s3.secret-key) are not set. Depends on D11224.

Test Plan

I'm not 100% sure about how to test this.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3595
Build 4875: [Placeholder Plan] Wait for 30 Seconds
Build 3603: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26955.Jan 5 2015, 9:06 PM

joshuaspence retitled this revision from to Disable S3 file storage engine without credentials.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D11224: Allow custom storage engines to be identified automatically.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 5 2015, 9:06 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence edited the test plan for this revision. (Show Details)Jan 6 2015, 8:58 PM

joshuaspence edited edge metadata.

Rolled into D12053.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

engine/

PhabricatorS3FileStorageEngine.php

3 lines

Diff 26955

src/applications/files/engine/PhabricatorS3FileStorageEngine.php

Loading...