Differential D11174

Specify the `config` property of `lint-test` files as a `map`
ClosedPublic
Actions

Authored by joshuaspence on Jan 3 2015, 5:01 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCa9cfc17688ec: Specify the `config` property of `lint-test` files as a `map`

Summary

Self-explanatory. This is implied anyway as we iterate over it with a foreach loop.

Test Plan

arc unit

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26824.Jan 3 2015, 5:01 AM

joshuaspence retitled this revision from to Specify the `config` property of `lint-test` files as a `map`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 3 2015, 5:01 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence updated this object.Jan 3 2015, 7:23 AM

joshuaspence edited edge metadata.

joshuaspence added a child revision: D11176: Modify the `lint-test` file format to allow for more powerful assertions.Jan 3 2015, 9:52 AM

epriestley accepted this revision.Jan 3 2015, 12:33 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 3 2015, 12:33 PM

Closed by commit rARCa9cfc17688ec: Specify the `config` property of `lint-test` files as a `map` (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 3 2015, 12:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

ArcanistLinterTestCase.php

2 lines

Diff 26835

View Options

src/lint/linter/tests/ArcanistLinterTestCase.php

Specify the `config` property of `lint-test` files as a `map`ClosedPublicActions