Paths

Table of Contentst

Differential D11165

Remove a TODO comment
ClosedPublic
Actions

Authored by joshuaspence on Jan 3 2015, 12:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 17, 11:08 PM

	Unknown Object (File)
	Sat, Dec 14, 2:23 PM

	Unknown Object (File)
	Wed, Dec 11, 1:56 PM

	Unknown Object (File)
	Fri, Dec 6, 11:25 PM

	Unknown Object (File)
	Tue, Dec 3, 10:16 AM

	Unknown Object (File)
	Fri, Nov 29, 4:58 AM

	Unknown Object (File)
	Mon, Nov 25, 7:34 AM

	Unknown Object (File)
	Fri, Nov 22, 1:57 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6852: Buttons break out of box when registering new users

Commits

Restricted Diffusion Commit
rP9a77c1636b0a: Remove a TODO comment

Summary

Ref T6852. Apparently, this is not a TODO.

Test Plan

N/A

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26811.Jan 3 2015, 12:48 AM

joshuaspence retitled this revision from to Remove a TODO comment.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T6852: Buttons break out of box when registering new users.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 3 2015, 12:48 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 3 2015, 12:49 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 3 2015, 12:49 AM

chad added a subscriber: chad.Jan 3 2015, 1:02 AM

chad added inline comments.

src/view/form/control/AphrontFormControl.php
225	You could also add `$classes[] = 'grouped';` here, but some members of the team may frown on that.

Closed by commit rP9a77c1636b0a: Remove a TODO comment (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 3 2015, 1:23 AM

This revision was automatically updated to reflect the committed changes.

I think there may be a reason that "grouped" wasn't used here -- IIRC, it cuts off tokenizer dropdowns and the calendar date selection popup thing.

mayhaps good sir, mayhaps.

Oh grouped doesn't hide overflow, it should have been fine. At least a quick test and those cases still work. I think grouped is just "clearfix" without older browser support if I recall (like IE6, IE7, IE Mac, etc).

Revision Contents
Changeset List

Path

Size

src/

view/

form/

control/

AphrontFormControl.php

2 lines

Diff 26814

src/view/form/control/AphrontFormControl.php

Loading...