Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T6484: Conduit API for SSH key retreival
- Commits
- Restricted Diffusion Commit
rPa7814b071c79: Add auth.querypublickeys to retrieve public keys
Ran method.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
src/applications/auth/conduit/PhabricatorAuthQueryPublicKeysConduitAPIMethod.php | ||
---|---|---|
71–73 | This seems a little strange as opposed to just returning data? |
src/applications/auth/conduit/PhabricatorAuthQueryPublicKeysConduitAPIMethod.php | ||
---|---|---|
71–73 | The more modern stuff is returning a result like: array( 'data' => <list of results>, 'cursor' => <data for getting the next or previous page of results>, ) ...and then some other calls (like diffusion.querycommits) also return additional keys. This makes it easier for callers to paginate results. Although they could usually have figured out the right before / after cursors for results where the cursor is just an ID, some cases like Maniphest queries with a nonstandard order-by have a complex cursor that clients can't trivially compute. |