Differential D11137

Correctly identify symbols in `n_CLASS_STATIC_ACCESS`
ClosedPublic
Actions

Authored by joshuaspence on Jan 2 2015, 1:03 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6847: `phutil_symbols.php` does not correctly handle static method calls

Commits

rPHU20446fc6b6ac: Correctly label symbols in `n_CLASS_STATIC_ACCESS`

Summary

Fixes T6847. These symbols should always be classes, as interfaces cannot have methods defined.

Test Plan

test.php

<?php

Foo::bar();

> ./scripts/phutil_symbols.php test.php
{
  "have": [],
  "need": {
    "class": {
      "Foo": 7
    }
  },
  "xmap": []
}

(We should really have some test cases defined for this file)

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26744.Jan 2 2015, 1:03 AM

joshuaspence retitled this revision from to Correctly label symbols in `n_CLASS_STATIC_ACCESS`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T6847: `phutil_symbols.php` does not correctly handle static method calls.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 2 2015, 1:03 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence edited the test plan for this revision. (Show Details)Jan 2 2015, 1:03 AM

joshuaspence edited edge metadata.

joshuaspence retitled this revision from Correctly label symbols in `n_CLASS_STATIC_ACCESS` to Correctly identify symbols in `n_CLASS_STATIC_ACCESS`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

epriestley accepted this revision.Jan 2 2015, 1:41 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 2 2015, 1:41 AM

Closed by commit rPHU20446fc6b6ac: Correctly label symbols in `n_CLASS_STATIC_ACCESS` (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 2 2015, 4:19 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

scripts/

phutil_symbols.php

2 lines

Diff 26747

View Options

scripts/phutil_symbols.php

Correctly identify symbols in `n_CLASS_STATIC_ACCESS`ClosedPublicActions