Whilst we don't immediately gain anything by dropping support for old Conduit versions, version 6 has been in the wild for a long time now (see D4077).
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers
> echo '{"client": "arc", "clientVersion": 4, "user": "josh"}' | arc --conduit-uri=http://phabricator.local call-conduit 'conduit.connect' Waiting for JSON parameters on stdin... {"error":"NEW-ARC-VERSION","errorMessage":"NEW-ARC-VERSION: A new version of arc is available! You need to upgrade to connect to this server (you are running version 4, the server is running version 6).","response":null}
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 3447 Build 3454: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
FWIW, I wish arc --conduit-version 5 would work here, but it doesn't seem to work with the call-conduit workflow.
Comment Actions
I don't want to force users to upgrade without there being actual protocol changes, especially since the cost of leaving these lines around is very close to 0.
There are a nontrivial number of users on corporate installs that may be using a local clone or something, and this'll cause headaches.
We'll probably bump the version again sooner or later (maybe for T5955), although ideally we never need to ever again (thanks to methods like conduit.query and conduit.getcapabilities). Version bumping caused a bunch of suckage for for users who were forced to upgrade in the past.