Page MenuHomePhabricator

Improvements for D11085
ClosedPublic

Authored by joshuaspence on Dec 30 2014, 9:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 1:22 PM
Unknown Object (File)
Thu, Nov 14, 1:43 PM
Unknown Object (File)
Sun, Nov 10, 3:27 PM
Unknown Object (File)
Wed, Nov 6, 8:57 AM
Unknown Object (File)
Fri, Nov 1, 10:59 PM
Unknown Object (File)
Tue, Oct 29, 1:01 AM
Unknown Object (File)
Sun, Oct 27, 4:39 PM
Unknown Object (File)
Oct 19 2024, 7:42 AM
Subscribers

Details

Summary

In D11085, I attempted to fix this although I did so poorly. The intention was to format JSON as follows:

{
  "foo": "bar",
  "foobarbaz": []
}

But instead I had achieved this:

{
  "foo"      : "bar",
  "foobarbaz": []
}
Test Plan

Ran ./scripts/update_compat_info.php and inspected ./resources/php_compat_info.json.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3405
Build 3412: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Improvements for D11805.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.
joshuaspence retitled this revision from Improvements for D11805 to Improvements for D11085.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 31 2014, 3:47 PM
This revision was automatically updated to reflect the committed changes.