Page MenuHomePhabricator

Improvements for D11085
ClosedPublic

Authored by joshuaspence on Dec 30 2014, 9:53 PM.
Tags
None
Referenced Files
F15505484: D11094.diff
Tue, Apr 15, 3:19 AM
F15470011: D11094.id26633.diff
Fri, Apr 4, 6:58 PM
F15450835: D11094.id26656.diff
Fri, Mar 28, 6:32 PM
F15422355: D11094.id26656.diff
Mar 22 2025, 7:36 AM
F15416136: D11094.id26633.diff
Mar 20 2025, 9:29 AM
F15412001: D11094.id26656.diff
Mar 19 2025, 10:46 AM
F15407565: D11094.id.diff
Mar 18 2025, 6:22 PM
F15399972: D11094.diff
Mar 17 2025, 8:54 AM
Subscribers

Details

Summary

In D11085, I attempted to fix this although I did so poorly. The intention was to format JSON as follows:

{
  "foo": "bar",
  "foobarbaz": []
}

But instead I had achieved this:

{
  "foo"      : "bar",
  "foobarbaz": []
}
Test Plan

Ran ./scripts/update_compat_info.php and inspected ./resources/php_compat_info.json.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Improvements for D11805.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.
joshuaspence retitled this revision from Improvements for D11805 to Improvements for D11085.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 31 2014, 3:47 PM
This revision was automatically updated to reflect the committed changes.