Page MenuHomePhabricator
Differential D11072

Fix a few minor JSHint warnings
ClosedPublic
Actions

Authored by joshuaspence on Dec 30 2014, 10:41 AM.
Tags
None
Referenced Files
F13817019: D11072.diff
Thu, Sep 19, 9:28 PM
Unknown Object (File)
Sat, Sep 7, 1:49 PM
Unknown Object (File)
Wed, Sep 4, 11:53 PM
Unknown Object (File)
Tue, Aug 27, 4:33 PM
Unknown Object (File)
Mon, Aug 26, 11:20 AM
Unknown Object (File)
Fri, Aug 23, 6:30 AM
Unknown Object (File)
Aug 15 2024, 7:37 PM
Unknown Object (File)
Aug 14 2024, 7:23 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPfcc7dbbf1511: Fix a few minor JSHint warnings
Summary

Basically, don't assign expressions to a variable if the variable is unused.

Test Plan

arc lint

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3369
Build 3376: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26567.Dec 30 2014, 10:41 AM
joshuaspence retitled this revision from to Fix a few minor JSHint warnings.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 30 2014, 10:41 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Dec 30 2014, 11:02 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 11:02 AM
Closed by commit rPfcc7dbbf1511: Fix a few minor JSHint warnings (authored by joshuaspence, committed by epriestley). · Explain WhyDec 30 2014, 11:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
support/
aphlict/
server/
6 lines

Diff 26567

View Options

support/aphlict/server/aphlict_server.js

Loading...
Phabricator · Built by Phacility