Page MenuHomePhabricator
Differential D11072

Fix a few minor JSHint warnings
ClosedPublic
Actions

Authored by joshuaspence on Dec 30 2014, 10:41 AM.
Tags
None
Referenced Files
F15510945: D11072.diff
Wed, Apr 16, 10:21 PM
F15507454: D11072.diff
Tue, Apr 15, 7:48 PM
F15487506: D11072.id26567.diff
Thu, Apr 10, 2:42 PM
F15483192: D11072.id26585.diff
Wed, Apr 9, 10:34 AM
F15482310: D11072.id26567.diff
Wed, Apr 9, 4:22 AM
F15481633: D11072.id.diff
Tue, Apr 8, 10:16 PM
F15477843: D11072.diff
Mon, Apr 7, 6:16 PM
F15449170: D11072.diff
Fri, Mar 28, 8:42 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPfcc7dbbf1511: Fix a few minor JSHint warnings
Summary

Basically, don't assign expressions to a variable if the variable is unused.

Test Plan

arc lint

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26567.Dec 30 2014, 10:41 AM
joshuaspence retitled this revision from to Fix a few minor JSHint warnings.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 30 2014, 10:41 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Dec 30 2014, 11:02 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 11:02 AM
Closed by commit rPfcc7dbbf1511: Fix a few minor JSHint warnings (authored by joshuaspence, committed by epriestley). · Explain WhyDec 30 2014, 11:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
support/
aphlict/
server/
6 lines

Diff 26585

View Options

support/aphlict/server/aphlict_server.js

Loading...
Phabricator · Built by Phacility