Page MenuHomePhabricator
Differential D11071

Define a seperate JSHint configuration for NodeJS files
ClosedPublic
Actions

Authored by joshuaspence on Dec 30 2014, 10:37 AM.
Tags
None
Referenced Files
F15925589: D11071.id26564.diff
Mon, Jun 2, 3:10 AM
Unknown Object (File)
Wed, May 28, 4:13 PM
Unknown Object (File)
Wed, May 21, 3:27 AM
Unknown Object (File)
Fri, May 9, 8:20 PM
Unknown Object (File)
Thu, May 8, 6:08 AM
Unknown Object (File)
Wed, May 7, 3:47 PM
Unknown Object (File)
Wed, May 7, 2:20 PM
Unknown Object (File)
Tue, May 6, 1:35 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPb6e0c76c7d6b: Define a seperate JSHint configuration for NodeJS files
Summary

Currently, we assume that all JavaScript files are for use in a browser. This is not true for the NodeJS Aphlict server code. Split the current JSHint configuration into jshint-browser and jshint-node.

Test Plan

arc lint

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26564.Dec 30 2014, 10:37 AM
joshuaspence retitled this revision from to Define a seperate JSHint configuration for NodeJS files.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 30 2014, 10:37 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 26565.Dec 30 2014, 10:39 AM
joshuaspence edited edge metadata.

Fix paths

epriestley accepted this revision.Dec 30 2014, 10:59 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 10:59 AM
epriestley requested changes to this revision.Dec 30 2014, 11:01 AM
epriestley edited edge metadata.

This interacted with D11069, yell if I got the merge wrong.

This revision now requires changes to proceed.Dec 30 2014, 11:01 AM
epriestley accepted this revision.Dec 30 2014, 11:01 AM
epriestley edited edge metadata.

Whoops, didn't mean to request changes.

This revision is now accepted and ready to land.Dec 30 2014, 11:01 AM
Closed by commit rPb6e0c76c7d6b: Define a seperate JSHint configuration for NodeJS files (authored by joshuaspence, committed by epriestley). · Explain WhyDec 30 2014, 11:02 AM
This revision was automatically updated to reflect the committed changes.
joshuaspence added a comment.Dec 30 2014, 11:04 AM

LGTM. I could've landed it myself (unless you've changed your policies lately I guess).

Revision Contents
Changeset List

PathSize
14 lines
support/
lint/
3 lines

Diff 26584

View Options

.arclint

Loading...
View Options

support/lint/browser.jshintrc

Loading...
View Options

support/lint/jshintrc

Loading...
View Options

support/lint/node.jshintrc

Loading...
Phabricator · Built by Phacility