Page MenuHomePhabricator

Use `window.confirm` instead of `confirm`
ClosedPublic

Authored by joshuaspence on Dec 30 2014, 10:17 AM.
Tags
None
Referenced Files
F18744953: D11065.id.diff
Fri, Oct 3, 4:47 AM
F18738138: D11065.id26558.diff
Wed, Oct 1, 2:16 PM
F18207245: D11065.id26578.diff
Aug 18 2025, 5:04 PM
F18193020: D11065.id.diff
Aug 17 2025, 4:54 AM
F18179304: D11065.diff
Aug 16 2025, 3:22 AM
F17870152: D11065.diff
Jul 28 2025, 1:15 PM
F17866907: D11065.id26558.diff
Jul 28 2025, 5:10 AM
F17842395: D11065.id26578.diff
Jul 26 2025, 11:34 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP5251f08fb432: Use `window.confirm` instead of `confirm`
Summary

This silences the following JSHint warning:

>>> Lint for webroot/rsrc/js/application/uiexample/notification-example.js:

   Warning  (W117) JSHintW117
    'confirm' is not defined.

              39           notification.listen(
              40             'activate',
              41             function() {
    >>>       42               if (!confirm('Close notification?')) {
              43                 JX.Stratcom.context().kill();
              44               }
              45             });
Test Plan

arc lint

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Use `window.confirm` instead of `confirm`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 10:53 AM
This revision was automatically updated to reflect the committed changes.