Paths

Table of Contentst

Differential D11063

Let JSHint know that the `show_details` function is an exported global
ClosedPublic
Actions

Authored by joshuaspence on Dec 30 2014, 10:01 AM.

Tags

None

Referenced Files

	F18342271: D11063.diff
	Tue, Aug 26, 4:23 AM

	F18222268: D11063.id.diff
	Tue, Aug 19, 8:37 PM

	F18216238: D11063.id26554.diff
	Tue, Aug 19, 7:33 AM

	F18201173: D11063.diff
	Mon, Aug 18, 6:38 AM

	F18106789: D11063.id26554.diff
	Sun, Aug 10, 11:22 PM

	F18106401: D11063.id.diff
	Sun, Aug 10, 10:33 PM

	Unknown Object (File)
	Jun 15 2025, 4:53 AM

	Unknown Object (File)
	Jun 15 2025, 4:52 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPe6684af73cec: Let JSHint know that the `show_details` function is an exported global

Summary

The show_details function is used by DarkConsole. Adding this comment silences the following JSHint warning:

>>> Lint for webroot/rsrc/js/core/behavior-error-log.js:

   Warning  (W098) JSHintW098
    'show_details' is defined but never used.

               5
               6 var current_details = null;
               7
    >>>        8 function show_details(row) {
               9   var node = JX.$('row-details-' + row);
              10
              11   if (current_details !== null) {

Test Plan

arc lint

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3356
Build 3363: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26554.Dec 30 2014, 10:01 AM

joshuaspence retitled this revision from to Let JSHint know that the `show_details` function is an exported global.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 30 2014, 10:01 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

This should probably get cleaned up more completely at some point.

This revision is now accepted and ready to land.Dec 30 2014, 10:51 AM

Closed by commit rPe6684af73cec: Let JSHint know that the `show_details` function is an exported global (authored by joshuaspence, committed by epriestley). · Explain WhyDec 30 2014, 10:51 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

webroot/

rsrc/

js/

core/

behavior-error-log.js

2 lines

Diff 26554

webroot/rsrc/js/core/behavior-error-log.js

Loading...