Paths

Table of Contentst

Differential D11063

Let JSHint know that the `show_details` function is an exported global
ClosedPublic
Actions

Authored by joshuaspence on Dec 30 2014, 10:01 AM.

Tags

None

Referenced Files

	F14035198: D11063.diff
	Sun, Nov 10, 4:50 AM

	F14021957: D11063.diff
	Wed, Nov 6, 2:09 PM

	F14007429: D11063.diff
	Tue, Oct 29, 5:45 AM

	F13970086: D11063.id.diff
	Thu, Oct 17, 5:40 AM

	Unknown Object (File)
	Oct 3 2024, 3:59 PM

	Unknown Object (File)
	Sep 6 2024, 7:29 PM

	Unknown Object (File)
	Sep 6 2024, 2:24 AM

	Unknown Object (File)
	Aug 29 2024, 10:42 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPe6684af73cec: Let JSHint know that the `show_details` function is an exported global

Summary

The show_details function is used by DarkConsole. Adding this comment silences the following JSHint warning:

>>> Lint for webroot/rsrc/js/core/behavior-error-log.js:

   Warning  (W098) JSHintW098
    'show_details' is defined but never used.

               5
               6 var current_details = null;
               7
    >>>        8 function show_details(row) {
               9   var node = JX.$('row-details-' + row);
              10
              11   if (current_details !== null) {

Test Plan

arc lint

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26554.Dec 30 2014, 10:01 AM

joshuaspence retitled this revision from to Let JSHint know that the `show_details` function is an exported global.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 30 2014, 10:01 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

This should probably get cleaned up more completely at some point.

This revision is now accepted and ready to land.Dec 30 2014, 10:51 AM

Closed by commit rPe6684af73cec: Let JSHint know that the `show_details` function is an exported global (authored by joshuaspence, committed by epriestley). · Explain WhyDec 30 2014, 10:51 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

12 lines

webroot/

rsrc/

js/

core/

behavior-error-log.js

2 lines

Diff 26576

resources/celerity/map.php

Loading...

webroot/rsrc/js/core/behavior-error-log.js

Loading...