Page MenuHomePhabricator
Differential D11062

Minor JavaScript fix
ClosedPublic
Actions

Authored by joshuaspence on Dec 30 2014, 9:51 AM.
Tags
None
Referenced Files
F15473932: D11062.id26553.diff
Sun, Apr 6, 3:26 AM
F15434371: D11062.diff
Tue, Mar 25, 3:14 AM
F15433945: D11062.id26553.diff
Tue, Mar 25, 1:19 AM
F15433944: D11062.id26575.diff
Tue, Mar 25, 1:19 AM
F15433943: D11062.id.diff
Tue, Mar 25, 1:19 AM
F15335097: D11062.id.diff
Sat, Mar 8, 2:19 PM
F15311725: D11062.diff
Mar 6 2025, 10:27 AM
F15285762: D11062.diff
Mar 4 2025, 3:57 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP3f0bc79e0ab1: Minor JavaScript fix
Summary

Currently, editdata is implicitly defined as a global variable (and JSHint complains about this). Instead, change it to be a local variable.

Test Plan

arc lint showed one less warning.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3355
Build 3362: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26553.Dec 30 2014, 9:51 AM
joshuaspence retitled this revision from to Minor JavaScript fix.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 30 2014, 9:51 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Dec 30 2014, 10:50 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 10:50 AM
Closed by commit rP3f0bc79e0ab1: Minor JavaScript fix (authored by joshuaspence, committed by epriestley). · Explain WhyDec 30 2014, 10:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
webroot/
rsrc/
js/
core/
2 lines

Diff 26553

View Options

webroot/rsrc/js/core/behavior-line-linker.js

Loading...
Phabricator · Built by Phacility