Paths

Table of Contentst

Minor JavaScript fix
ClosedPublic
Actions

Authored by joshuaspence on Dec 30 2014, 9:51 AM.

Tags

None

Referenced Files

	F15335097: D11062.id.diff
	Sat, Mar 8, 2:19 PM

	F15311725: D11062.diff
	Thu, Mar 6, 10:27 AM

	F15285762: D11062.diff
	Tue, Mar 4, 3:57 PM

	F15283494: D11062.id26575.diff
	Tue, Mar 4, 7:34 AM

	Unknown Object (File)
	Tue, Feb 25, 11:14 AM

	Unknown Object (File)
	Sun, Feb 23, 9:50 AM

	Unknown Object (File)
	Feb 13 2025, 6:54 AM

	Unknown Object (File)
	Feb 2 2025, 8:15 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP3f0bc79e0ab1: Minor JavaScript fix

Summary

Currently, editdata is implicitly defined as a global variable (and JSHint complains about this). Instead, change it to be a local variable.

Test Plan

arc lint showed one less warning.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26553.Dec 30 2014, 9:51 AM

joshuaspence retitled this revision from to Minor JavaScript fix.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 30 2014, 9:51 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Dec 30 2014, 10:50 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 30 2014, 10:50 AM

Closed by commit rP3f0bc79e0ab1: Minor JavaScript fix (authored by joshuaspence, committed by epriestley). · Explain WhyDec 30 2014, 10:50 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

16 lines

webroot/

rsrc/

js/

core/

behavior-line-linker.js

2 lines

Diff 26575

View Options

resources/celerity/map.php