Ref T5402. This more or less "fixes" it but there's probably some polish to do?
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T5402: Record `objectPHID` on queue tasks, as a debugging hint
- Commits
- Restricted Diffusion Commit
rP9219645287e9: Daemons - add "objectPHID" to task tables.
stopped and started daemons. error logs look good.
ran bin/storage upgrade. noted that adjust added the appropriate indices for active and archive task.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T5402
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 3331 Build 3338: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php | ||
|---|---|---|
| 185 | typo, will fix | |
Comment Actions
I thiiiiiink the second thing is a real issue?
| src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php | ||
|---|---|---|
| 185 | Should be %Ls. | |
| src/infrastructure/daemon/workers/storage/PhabricatorWorkerTask.php | ||
| 30 | For consistency, prefer key_object. (Do the subclasses override this and do anything funky? I seem to remember there being some weird things here. I'd expect the subclasses might need to do a $value = $value + $parent[self::CONFIG_KEY_SCHEMA] sort of thing, or we'll end up with a bunch of database issues and/or storage adjust destroying a pile of keys?) | |