Paths

Table of Contentst

Differential D11044

Daemons - add "objectPHID" to task tables.
ClosedPublic
Actions

Authored by btrahan on Dec 24 2014, 12:18 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 25, 12:55 AM

	Unknown Object (File)
	Sun, Apr 21, 9:10 PM

	Unknown Object (File)
	Thu, Apr 11, 8:40 AM

	Unknown Object (File)
	Thu, Apr 11, 12:52 AM

	Unknown Object (File)
	Thu, Apr 4, 9:48 AM

	Unknown Object (File)
	Thu, Apr 4, 8:32 AM

	Unknown Object (File)
	Feb 28 2024, 5:48 AM

	Unknown Object (File)
	Feb 12 2024, 3:20 AM

Subscribers

Tokens

"Mountain of Wealth" token, awarded by epriestley.

Details

Reviewers

Maniphest Tasks

T5402: Record `objectPHID` on queue tasks, as a debugging hint

Commits

Restricted Diffusion Commit
rP9219645287e9: Daemons - add "objectPHID" to task tables.

Summary

Ref T5402. This more or less "fixes" it but there's probably some polish to do?

Test Plan

stopped and started daemons. error logs look good.

ran bin/storage upgrade. noted that adjust added the appropriate indices for active and archive task.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 26521.Dec 24 2014, 12:18 AM

btrahan added a task: T5402: Record `objectPHID` on queue tasks, as a debugging hint.

btrahan retitled this revision from to Daemons - add "objectPHID" to task tables..

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 24 2014, 12:18 AM

btrahan added inline comments.Dec 24 2014, 12:20 AM

src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php
185	typo, will fix

%Ld => %Ls

I thiiiiiink the second thing is a real issue?

src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php
185	Should be `%Ls`.
src/infrastructure/daemon/workers/storage/PhabricatorWorkerTask.php
30	For consistency, prefer `key_object`. (Do the subclasses override this and do anything funky? I seem to remember there being some weird things here. I'd expect the subclasses might need to do a `$value = $value + $parent[self::CONFIG_KEY_SCHEMA]` sort of thing, or we'll end up with a bunch of database issues and/or `storage adjust` destroying a pile of keys?)

This revision now requires changes to proceed.Dec 24 2014, 12:22 AM

epriestley awarded a token.Dec 24 2014, 12:22 AM

key_object as preferred
add in the parent config for keys

btrahan edited the test plan for this revision. (Show Details)Dec 24 2014, 12:28 AM

btrahan edited edge metadata.

Awesome, this looks like exactly what I'm after.

This revision is now accepted and ready to land.Dec 24 2014, 12:29 AM

Closed by commit rP9219645287e9: Daemons - add "objectPHID" to task tables. (authored by btrahan, committed by btrahan). · Explain WhyDec 24 2014, 12:30 AM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D11211: Correctly pass worker priority from reparse script.Jan 4 2015, 9:22 PM

joshuaspence mentioned this in rPe12f0bb53aaf: Correctly pass worker priority from reparse script.Jan 4 2015, 9:34 PM

epriestley mentioned this in D21531: Add support for a "containerPHID" in the worker queue.Jan 29 2021, 12:33 AM

epriestley mentioned this in rP201e0d29435c: Add support for a "containerPHID" in the worker queue.Feb 2 2021, 9:40 PM

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20141223.daemonobjectphid.sql

5 lines

src/

applications/

diffusion/

engine/

DiffusionCommitHookEngine.php

4 lines

metamta/

management/

PhabricatorMailManagementResendWorkflow.php

4 lines

storage/

PhabricatorMetaMTAMail.php

4 lines

search/

index/

PhabricatorSearchIndexer.php

4 lines

infrastructure/

daemon/

workers/

PhabricatorWorker.php

10 lines

__tests__/

PhabricatorWorkerTestCase.php

2 lines

query/

PhabricatorWorkerLeaseQuery.php

10 lines

storage/

PhabricatorWorkerActiveTask.php

9 lines

PhabricatorWorkerArchiveTask.php

6 lines

PhabricatorWorkerTask.php

7 lines

sms/

adapter/

PhabricatorSMSImplementationAdapter.php

4 lines

Diff 26524

resources/sql/autopatches/20141223.daemonobjectphid.sql

Loading...

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...

src/applications/metamta/management/PhabricatorMailManagementResendWorkflow.php

Loading...

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

Loading...

src/applications/search/index/PhabricatorSearchIndexer.php

Loading...

src/infrastructure/daemon/workers/PhabricatorWorker.php

Loading...

src/infrastructure/daemon/workers/tests/PhabricatorWorkerTestCase.php

Loading...

src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php

Loading...

src/infrastructure/daemon/workers/storage/PhabricatorWorkerActiveTask.php

Loading...

src/infrastructure/daemon/workers/storage/PhabricatorWorkerArchiveTask.php

Loading...

src/infrastructure/daemon/workers/storage/PhabricatorWorkerTask.php

Loading...

src/infrastructure/sms/adapter/PhabricatorSMSImplementationAdapter.php

Loading...