Differential D11037

Catch undefinied title attribute in lightbox
ClosedPublic
Actions

Authored by chad on Dec 23 2014, 5:23 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T6793: Image lightbox has useless tooltip saying "undefined"

Commits

Restricted Diffusion Commit
rP06a3cf04fe74: Catch undefinied title attribute in lightbox

Summary

If the image name in not defined, don't set it. Fixes T6793

Test Plan

View a lightboxed image, no 'undefined' alt tag

Diff Detail

Repository

rP Phabricator

Branch

lb-undefined

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3324
Build 3331: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 26503.Dec 23 2014, 5:23 PM

chad retitled this revision from to Catch undefinied title attribute in lightbox.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T6793: Image lightbox has useless tooltip saying "undefined".

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 23 2014, 5:23 PM

epriestley accepted this revision.Dec 23 2014, 5:28 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 23 2014, 5:28 PM

Closed by commit rP06a3cf04fe74: Catch undefinied title attribute in lightbox (authored by chad, committed by chad). · Explain WhyDec 23 2014, 5:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

22 lines

webroot/

rsrc/

js/

core/

behavior-lightbox-attachments.js

8 lines

Diff 26503

View Options

resources/celerity/map.php