HomePhabricator
Diffusion Phabricator 06a3cf04fe74

Catch undefinied title attribute in lightbox
06a3cf04fe74
Actions

Description

Catch undefinied title attribute in lightbox

Summary: If the image name in not defined, don't set it. Fixes T6793

Test Plan: View a lightboxed image, no 'undefined' alt tag

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6793

Differential Revision: https://secure.phabricator.com/D11037

Details

Provenance
chadAuthored on
chadPushed on Dec 23 2014, 5:28 PM
Reviewer
epriestley
Differential Revision
D11037: Catch undefinied title attribute in lightbox
Parents
rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise
Branches
Unknown
Tags
Unknown
Tasks
T6793: Image lightbox has useless tooltip saying "undefined"

Event Timeline

chad committed rP06a3cf04fe74: Catch undefinied title attribute in lightbox (authored by chad).Dec 23 2014, 5:28 PM
chad added a task: T6793: Image lightbox has useless tooltip saying "undefined".
Krinkle added a subscriber: Krinkle.Jan 5 2015, 6:59 PM

The bug filed was about the title tooltip, not the alt text. Although the bug applied to both.

This commit removed the title attribute entirely, was that on purpose? I don't know what kind of value target_data.name hold and whether it's useful to display to the user.

chad added a comment.Jan 5 2015, 7:03 PM

Yes, removing both was on purpose. I never found it actually set, though it appears it should get set for uploaded non-image files.

Changes (2)

PathSize
resources/
celerity/
webroot/
rsrc/
js/
core/

rP06a3cf04fe74

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/core/behavior-lightbox-attachments.js

Loading...
Phabricator ยท Built by Phacility