Differential D11011

Switch normal query from match to simple_query_string
ClosedPublic
Actions

Authored by WikiChad on Dec 18 2014, 8:30 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6780: Can't search an exact phrase in Phabricator

Commits

Restricted Diffusion Commit
rPc953c0fedc17: Switch normal query from match to simple_query_string

Summary

It's like query_string but fails a little nicer on bad
input. It also allows for limited Lucene syntax; notably
exact string matches with quotation marks.

Fixes T6780

Test Plan

Tested multiple query constructions, including exact string
matching.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3289
Build 3296: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

WikiChad updated this revision to Diff 26440.Dec 18 2014, 8:30 PM

WikiChad retitled this revision from to Switch normal query from match to simple_query_string.

WikiChad updated this object.

WikiChad edited the test plan for this revision. (Show Details)

WikiChad added a task: T6780: Can't search an exact phrase in Phabricator.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 18 2014, 8:30 PM

Herald added a subscriber: epriestley. · View Herald Transcript

epriestley accepted this revision.Dec 22 2014, 9:00 PM

epriestley added a reviewer: epriestley.

This revision is now accepted and ready to land.Dec 22 2014, 9:00 PM

Closed by commit rPc953c0fedc17: Switch normal query from match to simple_query_string (authored by WikiChad, committed by epriestley). · Explain WhyDec 22 2014, 9:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

engine/

PhabricatorSearchEngineElastic.php

8 lines

Diff 26440

View Options

src/applications/search/engine/PhabricatorSearchEngineElastic.php

Switch normal query from match to simple_query_stringClosedPublicActions