Differential D10999

Fix a exception being thrown from Diviner
ClosedPublic
Actions

Authored by joshuaspence on Dec 17 2014, 3:35 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPed4c7893e900: Fix a exception being thrown from Diviner

Summary

If no Diviner groups are defined that this line currently throws a fatal exception... make this a little more safe.

Test Plan

Applied to our install, no more exceptions.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3271
Build 3277: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26412.Dec 17 2014, 3:35 AM

joshuaspence retitled this revision from to Fix a exception being thrown from Diviner.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 17 2014, 3:35 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Dec 17 2014, 5:40 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 17 2014, 5:40 AM

Closed by commit rPed4c7893e900: Fix a exception being thrown from Diviner (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 17 2014, 7:21 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diviner/

storage/

DivinerLiveBook.php

2 lines

Diff 26412

View Options

src/applications/diviner/storage/DivinerLiveBook.php

Fix a exception being thrown from DivinerClosedPublicActions