text linter: Allow disabling UNIX newline check
Needs RevisionPublic
Actions

Authored by ite-klass on Dec 12 2014, 4:21 PM.

Details

Reviewers

joshuaspence

Group Reviewers

Blessed Reviewers

Summary

Add CR as allowed character when checking for charset.
- The text linter can now be used for windows-CRLF-style files

by disabling the newline check.

Test Plan

Ran arc lint on a local project with windows java files.
Verified that it caused newline errors when not disabled. Verified
that it stops posting charset errors upon adding CR as allowed character.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3244
Build 3250: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

ite-klass updated this revision to Diff 26363.Dec 12 2014, 4:21 PM

ite-klass retitled this revision from to text linter: Allow disabling UNIX newline check.

ite-klass updated this object.

ite-klass edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 12 2014, 4:21 PM

Herald added a subscriber: epriestley. · View Herald Transcript

First change for T6739

Adjust charset error message to match new rules (having added CR as allowed character).

joshuaspence added a subscriber: joshuaspence.Feb 26 2015, 12:03 AM

See D11458 for the more comprehensive solution. In the mean time, you should be able to disable the newline checks via the arclint file:

.arclint

{
  "linters": {
    "text": {
      "severity": {
        "1": "disabled"
      }
    }
  }
}

This revision now requires changes to proceed.Mar 1 2015, 9:28 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistTextLinter.php

26 lines

Diff 26364

View Options

src/lint/linter/ArcanistTextLinter.php

text linter: Allow disabling UNIX newline checkNeeds RevisionPublicActions