Properly ensure timeline items have a 1px spacer
ClosedPublic
Actions

Authored by chad on Dec 11 2014, 5:20 AM.

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rPe63b62fa7821: Properly ensure timeline items have a 1px spacer

Summary

Some browsers, mobile, didn't show 1px space between objects (due to font renderings). This enforces the size for consistent cross-browser display.

Test Plan

Test IE10

Diff Detail

Repository

rP Phabricator

Branch

timeline-space

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3230
Build 3236: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 26342.Dec 11 2014, 5:20 AM

chad retitled this revision from to Properly ensure timeline items have a 1px spacer.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 11 2014, 5:20 AM

epriestley accepted this revision.Dec 11 2014, 12:06 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 11 2014, 12:06 PM

Closed by commit rPe63b62fa7821: Properly ensure timeline items have a 1px spacer (authored by chad, committed by chad). · Explain WhyDec 11 2014, 3:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-timeline-view.css

2 lines

Diff 26342

View Options

resources/celerity/map.php