HomePhabricator

Don't run Herald when applying inverse edge transactions

Tags
None
Referenced Files
None
Subscribers
None
Tokens
"Grey Medal" token, awarded by btrahan.

Description

Don't run Herald when applying inverse edge transactions

Summary: Fixes T6727. Repro is: mention a task on another task, in a comment.

The inverse edge editor applying the "alincoln mentioned this in <other task>" transaction doesn't have enough data to execute Herald rules.

Just don't try to execute the rules, since they don't make much sesne from a product perspective and are tricky from a technical perspective.

Test Plan: Commented on T1 with T2 in comment body and a Herald rule that examines subscribers.

Reviewers: btrahan

NOTE: Cowboy committing this since any task mention fatals.

Details

Group Auditors
Cowboy Commits
Provenance
epriestleyAuthored on
epriestleyPushed on Dec 11 2014, 12:54 AM
Parents
rP7d9687057056: Maniphest - use subscribers framework properly
Branches
Unknown
Tags
Unknown
Tasks
T6727: Missing a needSubscribers() in Herald