Implement more correct white-icon menu behavior
ClosedPublic
Actions

Authored by epriestley on Dec 11 2014, 12:20 AM.

Tags

None

Referenced Files

	F13227657: D10967.id26336.diff
	Mon, May 20, 4:46 AM

	F13223873: D10967.id26337.diff
	Sun, May 19, 5:11 AM

	F13221564: D10967.diff
	Sun, May 19, 2:52 AM

	F13203976: D10967.diff
	Wed, May 15, 12:15 AM

	F13186673: D10967.diff
	Sat, May 11, 3:48 AM

	Unknown Object (File)
	Tue, May 7, 7:07 AM

	Unknown Object (File)
	Fri, May 3, 5:12 AM

	Unknown Object (File)
	Mon, Apr 29, 12:27 AM

View All Files

Subscribers

epriestley

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rP3297bc2ed914: Implement more correct white-icon menu behavior

Summary

I didn't get this quite right.

Test Plan

Clicked to open, saw white, then closed by:
- Clicking document outside menu;
- clicking menu icon again;
- clicking a different menu icon.
In all three cases, got correct close + un-white behavior.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 26336.Dec 11 2014, 12:20 AM

epriestley retitled this revision from to Implement more correct white-icon menu behavior.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

Herald added a subscriber: epriestley. · View Herald TranscriptDec 11 2014, 12:20 AM

haha

This revision is now accepted and ready to land.Dec 11 2014, 12:26 AM

sorry you had to write more JS

Closed by commit rP3297bc2ed914: Implement more correct white-icon menu behavior (authored by epriestley, committed by epriestley). · Explain WhyDec 11 2014, 12:26 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

26 lines

webroot/

rsrc/

js/

application/

aphlict/

behavior-aphlict-dropdown.js

34 lines

Diff 26337

View Options

resources/celerity/map.php