Differential D10967

Implement more correct white-icon menu behavior
ClosedPublic
Actions

Authored by epriestley on Dec 11 2014, 12:20 AM.

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rP3297bc2ed914: Implement more correct white-icon menu behavior

Summary

I didn't get this quite right.

Test Plan

Clicked to open, saw white, then closed by:
- Clicking document outside menu;
- clicking menu icon again;
- clicking a different menu icon.
In all three cases, got correct close + un-white behavior.

Diff Detail

Repository

rP Phabricator

Branch

white2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3227
Build 3233: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 26336.Dec 11 2014, 12:20 AM

epriestley retitled this revision from to Implement more correct white-icon menu behavior.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

Herald added a subscriber: epriestley. · View Herald TranscriptDec 11 2014, 12:20 AM

haha

This revision is now accepted and ready to land.Dec 11 2014, 12:26 AM

sorry you had to write more JS

Closed by commit rP3297bc2ed914: Implement more correct white-icon menu behavior (authored by epriestley, committed by epriestley). · Explain WhyDec 11 2014, 12:26 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

26 lines

webroot/

rsrc/

js/

application/

aphlict/

behavior-aphlict-dropdown.js

34 lines

Diff 26336

View Options

resources/celerity/map.php