This allows browsers (Chorme, Firefox) to add Phabricator as a search engine.
The CSRF token that was previously generated (as it was a POST) was not checked anyway, and I don't think this is exploitable.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers
Right clicked on Chrome, as "Add As Search Engine". Tried out the search and it worked.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- dont_force_search_to_post
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 3207 Build 3213: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
We haven't seen other interest in this so I'm not interested in bringing it upstream.