Page MenuHomePhabricator
Differential D10948

Update message and notification icons to use fonts
ClosedPublic
Actions

Authored by chad on Dec 8 2014, 9:50 PM.
Tags
None
Referenced Files
F14817399: D10948.id.diff
Tue, Jan 28, 1:14 AM
Unknown Object (File)
Sat, Jan 25, 8:35 PM
Unknown Object (File)
Thu, Jan 23, 6:57 PM
Unknown Object (File)
Thu, Jan 23, 6:57 PM
Unknown Object (File)
Thu, Jan 23, 6:00 PM
Unknown Object (File)
Sat, Jan 18, 2:23 AM
Unknown Object (File)
Dec 19 2024, 1:22 PM
Unknown Object (File)
Dec 19 2024, 1:22 PM
View All Files
Subscribers
epriestley
Korvin
richardvanvelzen

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP34fb98da66ea: Update message and notification icons to use fonts
Summary

Cleans up spacing, updates to fonts instead of images. Fixed some mobile issues.

Test Plan

Test with and without counts on desktop, tablet, mobile. Test layout in FF, Chrome, IE.

Screen_Shot_2014-12-08_at_1.48.57_PM.png (178×528 px, 46 KB)

Screen_Shot_2014-12-08_at_1.49.08_PM.png (162×528 px, 40 KB)

Diff Detail

Repository
rP Phabricator
Branch
notifications-font-icon
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3200
Build 3206: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 26292.Dec 8 2014, 9:50 PM
chad retitled this revision from to Update message and notification icons to use fonts.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 8 2014, 9:50 PM
chad edited the test plan for this revision. (Show Details)Dec 8 2014, 9:51 PM
epriestley accepted this revision.Dec 8 2014, 9:51 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 8 2014, 9:51 PM
chad added a comment.EditedDec 8 2014, 9:52 PM

Unfortunately there isn't a usable in the font set, so changed to .

Closed by commit rP34fb98da66ea: Update message and notification icons to use fonts (authored by chad, committed by chad). · Explain WhyDec 8 2014, 9:53 PM
This revision was automatically updated to reflect the committed changes.
richardvanvelzen added a subscriber: richardvanvelzen.Dec 8 2014, 10:27 PM

I will miss the flame

Revision Contents
Changeset List

Diff 26292

View Options

resources/celerity/map.php

Loading...
View Options

resources/sprite/manifest/menu.json

Loading...
View Options

resources/sprite/menu_1x/conf-hover.png

Loading...
View Options

resources/sprite/menu_1x/conf-off.png

Loading...
View Options

resources/sprite/menu_1x/conf-unseen.png

Loading...
View Options

resources/sprite/menu_1x/seen_have_unread.png

Loading...
View Options

resources/sprite/menu_1x/seen_read_all.png

Loading...
View Options

resources/sprite/menu_1x/unseen_any.png

Loading...
View Options

resources/sprite/menu_2x/conf-hover.png

Loading...
View Options

resources/sprite/menu_2x/conf-off.png

Loading...
View Options

resources/sprite/menu_2x/conf-unseen.png

Loading...
View Options

resources/sprite/menu_2x/seen_have_unread.png

Loading...
View Options

resources/sprite/menu_2x/seen_read_all.png

Loading...
View Options

resources/sprite/menu_2x/unseen_any.png

Loading...
View Options

src/applications/celerity/CeleritySpriteGenerator.php

Loading...
View Options

src/view/page/menu/PhabricatorMainMenuView.php

Loading...
View Options

webroot/rsrc/css/application/base/main-menu-view.css

Loading...
View Options

webroot/rsrc/css/sprite-menu.css

Loading...
View Options

webroot/rsrc/image/sprite-menu-X2.png

Loading...
View Options

webroot/rsrc/image/sprite-menu.png

Loading...
Phabricator · Built by Phacility