Page MenuHomePhabricator

Support an explicit connection timeout parameter for database connections
ClosedPublic

Authored by epriestley on Dec 8 2014, 1:22 PM.
Tags
None
Referenced Files
F15517211: D10944.id26285.diff
Sat, Apr 19, 12:51 AM
F15495512: D10944.id26291.diff
Sun, Apr 13, 4:40 AM
F15461046: D10944.id26285.diff
Tue, Apr 1, 4:38 AM
F15441494: D10944.id.diff
Mar 26 2025, 6:30 PM
F15436316: D10944.diff
Mar 25 2025, 1:24 PM
F15396543: D10944.id26291.diff
Mar 16 2025, 2:59 PM
F15385125: D10944.id26285.diff
Mar 14 2025, 9:46 PM
Unknown Object (File)
Mar 3 2025, 2:59 PM
Subscribers

Details

Summary

Ref T6238. On the instance management interface, I want to check if an instance's database is reachable by connecting to it.

If it isn't, we hang for 30-60 seconds (default connection timeout). Allow explicit specification of a timeout when establishing a connection instead.

This only does MySQLi, not MySQL. We don't need MySQL for now, although it would be nice to support it eventually (Ref T6710).

Test Plan
  • Browsed around.
  • Used short timeouts to get instance database status in instance management.

Diff Detail

Repository
rPHU libphutil
Branch
timeout
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php:143XHP45PHP Compatibility
Unit
No Test Coverage
Build Status
Buildable 3196
Build 3202: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Support an explicit connection timeout parameter for database connections.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Dec 8 2014, 5:11 PM
This revision was automatically updated to reflect the committed changes.