Page MenuHomePhabricator
Differential D10939

Move cancel/retry/free task queue actions to bin/worker
ClosedPublic
Actions

Authored by epriestley on Dec 6 2014, 4:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 4:53 PM
Unknown Object (File)
Thu, Apr 4, 2:49 AM
Unknown Object (File)
Feb 15 2024, 11:12 PM
Unknown Object (File)
Feb 15 2024, 11:12 PM
Unknown Object (File)
Feb 14 2024, 9:41 PM
Unknown Object (File)
Feb 14 2024, 9:41 PM
Unknown Object (File)
Feb 14 2024, 9:41 PM
Unknown Object (File)
Feb 7 2024, 8:54 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T3554: Implement a `bin/worker kill <criteria>` for batch-flushing tasks from the queue
T6702: Any logged in user can cancel a queued task
Commits
Restricted Diffusion Commit
rP9a7383121dbb: Move cancel/retry/free task queue actions to bin/worker
Summary

Fixes T6702. Ref T3554. Currently, tasks can be cancelled, retried and freed from the web UI by any logged in user.

This isn't appreciably dangerous (I can't come up with a way that a user could do anything security-affecting), but I think I probably intended this to be admin-only, but these actions should move to the CLI anyway.

Move them to the CLI. Lay some groundwork for some future bin/worker cancel --class SomeTaskClass, but don't implement that yet.

Test Plan

Used cancel, retry and free from the CLI. Hit all the error/success states.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 26273.Dec 6 2014, 4:22 PM
epriestley retitled this revision from to Move cancel/retry/free task queue actions to bin/worker.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T6702: Any logged in user can cancel a queued task, T3554: Implement a `bin/worker kill <criteria>` for batch-flushing tasks from the queue.
Herald added a subscriber: epriestley. · View Herald TranscriptDec 6 2014, 4:22 PM
btrahan accepted this revision.Dec 6 2014, 5:05 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Dec 6 2014, 5:05 PM
Closed by commit rP9a7383121dbb: Move cancel/retry/free task queue actions to bin/worker (authored by epriestley, committed by epriestley). · Explain WhyDec 6 2014, 5:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 26274

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/daemon/application/PhabricatorDaemonsApplication.php

Loading...
View Options

src/applications/daemon/controller/PhabricatorWorkerTaskDetailController.php

Loading...
View Options

src/applications/daemon/controller/PhabricatorWorkerTaskUpdateController.php

Loading...
View Options

src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementCancelWorkflow.php

Loading...
View Options

src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementFreeWorkflow.php

Loading...
View Options

src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementRetryWorkflow.php

Loading...
View Options

src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementWorkflow.php

Loading...
Phabricator · Built by Phacility